Use BigInteger to prevent overflow in factorial calculation#7358
Merged
DenizAltunkapan merged 8 commits intoTheAlgorithms:masterfrom Apr 1, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7358 +/- ##
============================================
- Coverage 79.40% 79.39% -0.01%
- Complexity 7092 7093 +1
============================================
Files 792 792
Lines 23226 23226
Branches 4568 4568
============================================
- Hits 18443 18441 -2
- Misses 4046 4047 +1
- Partials 737 738 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DenizAltunkapan
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.javaDescription
Updated the
Factorial.javaimplementation to useBigIntegerinstead oflong.Reason for change:$n > 20$ . Since factorials grow exponentially,
The previous implementation using
longwould overflow for any inputBigIntegeris necessary to handle arbitrarily large results accurately without data loss.Changes:
BigInteger.BigInteger.multiply().IllegalArgumentException.