Skip to content

fix: respect projectIgnorePaths from socket.yml in scan create#1137

Open
mtorp wants to merge 6 commits intov1.xfrom
fix/scan-create-project-ignore-paths
Open

fix: respect projectIgnorePaths from socket.yml in scan create#1137
mtorp wants to merge 6 commits intov1.xfrom
fix/scan-create-project-ignore-paths

Conversation

@mtorp
Copy link
Copy Markdown
Contributor

@mtorp mtorp commented Mar 31, 2026

Summary

  • socket scan create now honors projectIgnorePaths from socket.yml when collecting files for a scan
  • The downstream glob infrastructure (globWithGitIgnore) already supported this, but the scan create command never loaded socket.yml — this wires it up by calling findSocketYmlSync(cwd) and passing the parsed config to getPackageFilesForScan
  • Removes the corresponding TODO comment in the help text

Test plan

  • Existing path-resolve.test.mts tests pass (11/11), including the "should respect ignores from socket config" test
  • Lint and type checks pass
  • Manual test: create a socket.yml with projectIgnorePaths entries and verify socket scan create --read-only excludes the specified paths

Note

Medium Risk
Moderate risk because it changes manifest discovery inputs for scans/reachability by applying socket.yml ignore rules, which can alter what gets uploaded and analyzed. The change is localized and uses existing glob/ignore plumbing.

Overview
Respects socket.yml ignores during scan file discovery. socket scan create and socket scan reach now call findSocketYmlSync(cwd) and pass the parsed config into getPackageFilesForScan, so projectIgnorePaths affects which local manifests are included.

Also removes a stale TODO in scan create help text and bumps the CLI version to 1.1.78 with an updated changelog entry.

Written by Cursor Bugbot for commit 55e3874. Configure here.

The scan create command had all the downstream infrastructure to honor
projectIgnorePaths from socket.yml but never actually loaded the config.
Read socket.yml via findSocketYmlSync and pass the parsed config to
getPackageFilesForScan so globWithGitIgnore applies the ignore patterns.
@mtorp mtorp changed the base branch from main to v1.x March 31, 2026 15:54
@mtorp mtorp requested a review from jdalton April 1, 2026 12:46
@mtorp mtorp marked this pull request as ready for review April 1, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant