Skip to content

Fix #8447: serialize order value with contract multiplier#9384

Closed
aiSynergy37 wants to merge 1 commit intoQuantConnect:masterfrom
aiSynergy37:bug-8447-order-serialization-value-multiplier-v2
Closed

Fix #8447: serialize order value with contract multiplier#9384
aiSynergy37 wants to merge 1 commit intoQuantConnect:masterfrom
aiSynergy37:bug-8447-order-serialization-value-multiplier-v2

Conversation

@aiSynergy37
Copy link
Copy Markdown
Contributor

What

  • Fixes order JSON serialization so �alue includes the symbol contract multiplier.
  • Adds regression coverage for option order serialization value in ReadOrdersResponseJsonConverterTests.
  • Updates option order fixture JSON values (camel and capital case) to the multiplier-adjusted value.

Why

Issue #8447 reports that serialized order value used Order.Value (quantity * price), which omits contract multiplier and is incorrect for derivatives like options.

How

  • In ReadOrdersResponseJsonConverter.WriteJson, compute serialized value using symbol properties from SymbolPropertiesDatabase and override jObject[value] with order.Value * contractMultiplier.
  • Keep existing behavior unchanged when order/symbol is unavailable.
  • Add a focused unit test asserting option serialization emits the multiplier-adjusted value.

Testing

  • Attempted: dotnet test Tests/QuantConnect.Tests.csproj --filter FullyQualifiedName~ReadOrdersResponseJsonConverterTests
  • Note: test execution is currently blocked in this environment by repository package vulnerability warnings (NU1902/NU1903/NU1904) that are treated as build-failing during package asset resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants