Safe to use methods after implementing essential ones

[xandfury]

Hi..
After discussion with Will, I was able to write a custom fs that overwrites the essential methods provided here. It does exactly what I expect it to do and I am pretty happy with it.
My question is : just after implementing these methods, what all non-essential methods are safe to use?

[willmcgugan]

If you've implemented the essential methods, you should have a working implementation, so all other methods will be safe to use...

[xandfury]

Thanks for clearing that up.

[xandfury]

I just noticed recently, setbinfile method used in move doesn't use my custom defined openbin method as can be observed here and here.
My openbin returns a custom file object that has to go under a setup and teardown process. Rather than using the openbin method defined in my class, setbinfile creates a new file object of type io.TextIOWrapper

To reproduce this, please check whether openbin is invoked during the call of move. I have added a custom move but I think we can chage this in it's implementation.

[willmcgugan]

setbinfile opens a file in binary mode, the default open calls the openbin method if there is a b in the mode.

If you think there is a bug in PyFilesystem, please try to identify what is going wrong (line number, traceback) etc. I'll need to know what I'm looking for before helping you debug...

Have you put a print statement in your setbinfile method? And is it return a binary file ?

[willmcgugan]

Please open a new issue if you identify a bug...