[WIP] Skip tests using managed memory if CU_DEVICE_ATTRIBUTE_CONCURRENT_MANAGED_ACCESS == 0#1576
Closed
rwgk wants to merge 10 commits intoNVIDIA:mainfrom
Closed
[WIP] Skip tests using managed memory if CU_DEVICE_ATTRIBUTE_CONCURRENT_MANAGED_ACCESS == 0#1576rwgk wants to merge 10 commits intoNVIDIA:mainfrom
CU_DEVICE_ATTRIBUTE_CONCURRENT_MANAGED_ACCESS == 0#1576rwgk wants to merge 10 commits intoNVIDIA:mainfrom
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
The temporary commit bddca29 is a trick to identify the tests we need to skip. Full build and test logs (internal access only); |
Treat missing cuMemAllocManaged as disabled access and gate managed-memory test paths in cuda_core and cuda_bindings to avoid false failures. Co-authored-by: Cursor <cursoragent@cursor.com>
…_core/tests/test_launcher.py::test_launch_invalid_values
Collaborator
Author
|
I backed out the band-aid change made with PR #1567 (commit 85f76f5) because it could later mask if we miss skips. Cursor-generated skips (commit b9f8452) pass local testing, with the Running the CI to see if we still have tests that depend on |
Collaborator
Author
|
/ok to test |
|
Move the managed-memory skip logic into cuda_python_test_helpers and point bindings/core tests at the shared module, with path bootstrapping to prefer in-repo helpers. This avoids relying on bindings test helpers that are absent in 12.9.x wheels. Co-authored-by: Cursor <cursoragent@cursor.com>
rwgk
force-pushed
the
avoid_managed_memory_on_windows
branch
from
71f271a to
a48565f
Compare
Collaborator
Author
|
Closing in favor of #1607 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
Removed preview folders for the following PRs: - PR #1576
Collaborator
Author
|
It looks like #1618/#1607 turned out different from what I was aiming for in this PR: resolving Windows flakiness. Reopening, so I don't forget to come back to this. (I got stuck a bit with this PR because of what's now solved under the pending #1218, specifically #1218 — Once that's merged, the test changes here should be easy.) |
rwgk
added
cuda.bindings
Made-with: Cursor
Reuse the shared managed-memory skip helper and keep the conftest import lazy so test bootstrap order stays intact without duplicate skip logic. Made-with: Cursor
Restore the cuMemAllocManaged binding, validate concurrent managed access per active device, and drop the test-helper skip for missing symbols. Made-with: Cursor
Collaborator
Author
|
/ok to test |
Force managed-memory skip checks to return None so tests run without CMA filtering. Made-with: Cursor
Collaborator
Author
|
/ok to test |
Collaborator
Author
|
The negative test (commit af0e03a) worked exactly as expected: However, in the meantime the idea of adding the guard code in |
Collaborator
Author
|
I want to backtrack to my main goal: our tests should not be flaky Background:
Here is a Cursor-generated analysis and concrete suggestions: What Becomes Undefined When
|
Collaborator
Author
|
Closing: see #1769 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes nvbug 5815123
Background: #1539
This PR will have two stages: 1. identify the tests we need to skip, 2. add the skips