Skip to content

cargo test: Fix proptest_read_to_end#36029

Open
def- wants to merge 1 commit intoMaterializeInc:mainfrom
def-:pr-fix-proptest
Open

cargo test: Fix proptest_read_to_end#36029
def- wants to merge 1 commit intoMaterializeInc:mainfrom
def-:pr-fix-proptest

Conversation

@def-
Copy link
Copy Markdown
Contributor

@def- def- commented Apr 13, 2026

Introduced in #18692

Introduced in MaterializeInc#18692

Comparing a value against itself makes the test useless
@def- def- requested review from SangJunBak and bosconi April 13, 2026 03:36
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant