Conversation
Codecov Report
@@ Coverage Diff @@
## develop #42 +/- ##
===========================================
+ Coverage 92.61% 92.78% +0.17%
===========================================
Files 109 115 +6
Lines 5401 5615 +214
Branches 941 973 +32
===========================================
+ Hits 5002 5210 +208
- Misses 309 311 +2
- Partials 90 94 +4
|
01d115a to
6141330
Compare
andy-takker
approved these changes
May 23, 2023
bebfdc6 to
0407427
Compare
dmitry-pedchenko
approved these changes
May 24, 2023
0407427 to
e118ca5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileMoverandMoveResultclasses. UsingFileDownloaderas a template, but no HWM, no tmp_path, and target path is remote.FileDownloadertests as a template.FileDownloaderandFileUploaderdocs:DownloadResultandFileSet.runusing absolute & relative pathsFileUploaderdoes not support read strategies, likeFileDownloader.FileDownloader&FileUploader- if debugging is enabled, print original exception stack trace.Docs: https://onetl--42.org.readthedocs.build/en/42/core/file_mover/index.html
Note: temporary added limit for
typing-extensionsversion because of python/typing_extensions#188