Optimize extract project by danlipsa · Pull Request #31 · Kitware/QuickView

danlipsa · 2026-03-26T14:30:30Z

No description provided.

Instead of using LongitudeRange,LatitudeRange properties which require knowing the range of the input we use TrimLongitude,TrimLatitude which specify how much to trim at each end of the input interval Hidden cells are used to restrict the mesh shown instead of changing the mesh. This allows us to reuse the VBO when rendering.

danlipsa · 2026-03-26T14:32:08Z

@jourdain Please review. This is not yet integrated into QuickView. I'll do that starting next Mon.

src/e3sm_quickview/plugins/eam_projection.py

jourdain · 2026-03-26T15:08:32Z

src/e3sm_quickview/plugins/eam_projection.py

+            _coords = numpy_support.numpy_to_vtk(outPoints, deep=True)
+            outData.GetPoints().SetData(_coords)
+            if self.cached_points:
+                self.cached_points.Unregister(self)


Rather than Unregister, should you just set self.cached_points = None?

Do I need to do this at all? If the python object is deleted, the c++ object should be unregistered as well, isn't it?

src/e3sm_quickview/plugins/eam_projection.py

jourdain · 2026-03-31T20:50:27Z

Where are we on that one? I'm about the merge my changes, and I was wondering if I should try to do that after your changes?

danlipsa · 2026-03-31T20:59:12Z

Those will work, but I'll need to add vtkPolyData::RemoveGhostCells(), possible in a different PR. For now we won't see the changes in the lat/lon range unless we add that function. Up to you if you merge or now.

jourdain · 2026-03-31T22:32:27Z

closing as it is included in #33

danlipsa added 5 commits March 25, 2026 14:55

fix: keep a reference to cached_output so it is not deleted

ed0fffa

fix: compare points and cell arrays modification time

de8d008

feat: cache cell_centers and ghosts in EAMExtract

d8bf17e

feat: add caching to EAMProject

bdc1dbd