Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an ASV benchmark suite for mkl_fft (root API + NumPy/SciPy interfaces + memory) along with configuration, docs, and ignore rules to support running and storing benchmark artifacts in CI.
Changes:
- Introduces ASV benchmark modules covering 1-D, 2-D, and N-D FFTs across multiple dtypes and shapes (including Hermitian variants for SciPy).
- Adds ASV configuration (
asv.conf.json) and documentation for local/CI execution. - Adds benchmark package initialization that pins thread counts via environment variables, plus
.gitignoreentries for ASV artifacts.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
benchmarks/benchmarks/bench_scipy_fft.py |
Adds full-coverage ASV benchmarks for mkl_fft.interfaces.scipy_fft including Hermitian 2-D/N-D. |
benchmarks/benchmarks/bench_numpy_fft.py |
Adds full-coverage ASV benchmarks for mkl_fft.interfaces.numpy_fft including Hermitian 1-D. |
benchmarks/benchmarks/bench_memory.py |
Adds ASV peak-RSS benchmarks for core mkl_fft transforms across 1-D/2-D/3-D. |
benchmarks/benchmarks/bench_fftnd.py |
Adds 2-D and N-D root-API benchmarks including non-square and non-power-of-two cases. |
benchmarks/benchmarks/bench_fft1d.py |
Adds 1-D root-API benchmarks for power-of-two and non-power-of-two sizes (C2C and R2C/C2R). |
benchmarks/benchmarks/__init__.py |
Adds thread pinning logic via MKL_NUM_THREADS/OMP_NUM_THREADS/OPENBLAS_NUM_THREADS. |
benchmarks/asv.conf.json |
Adds ASV project configuration (dirs, branches, timeouts, regression thresholds). |
benchmarks/README.md |
Documents benchmark structure, coverage, threading rationale, and local/CI run commands. |
.gitignore |
Ignores ASV artifact directories. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a complete ASV benchmark suite for mkl_fft and wires it into the internal Jenkins CI pipeline.
Benchmarks added (
benchmarks/benchmarks/):bench_fft1d.py— 1-D C2C and R2C/C2R, power-of-two and non-power-of-twobench_fftnd.py— 2-D and N-D C2C and R2C/C2R, square, non-square, non-power-of-twobench_numpy_fft.py— full coverage of mkl_fft.interfaces.numpy_fftbench_scipy_fft.py— full coverage of mkl_fft.interfaces.scipy_fft including Hermitian 2-D/N-Dbench_memory.py— peak RSS for 1-D, 2-D, and 3-D transforms__init__.py— pins MKL_NUM_THREADS=4 on machines with ≥4 physical cores for consistent cross-machine results (A hack to keep the results consistent on random nodes until CI finds a stable benchmarking machine)Config (
benchmarks/asv.conf.json)Docs (
benchmarks/README.md): structure, coverage, threading rationale, local run commands, CI flow.