Fixed in password resetting email link.#5656
Merged
kcondon merged 1 commit intoIQSS:developfrom Mar 18, 2019
Merged
Conversation
Use `siteUrl` to generate correct password resetting link.
Contributor
|
Hey @adoal, thanks for the PR. We'll take a look early next week. I'll let more technical members of the team weigh in on the PR itself, but I know that we do highly recommend HTTPS for Dataverse. That being said, this may be a good change regardless. |
pdurbin
approved these changes
Mar 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
siteUrlto generate correct password resetting link instead of hard-coded 'https://...'So that password resetting works if the site runs without https.