Skip to content

python-abseil: remove#163343

Merged
BrewTestBot merged 1 commit intoHomebrew:masterfrom
cho-m:python-abseil-remove
Feb 20, 2024
Merged

python-abseil: remove#163343
BrewTestBot merged 1 commit intoHomebrew:masterfrom
cho-m:python-abseil-remove

Conversation

@cho-m
Copy link
Copy Markdown
Member

@cho-m cho-m commented Feb 20, 2024

See #157500

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m added maintainer feedback Additional maintainers' opinions may be needed CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Feb 20, 2024
@github-actions github-actions bot added the marked for removal/rejection PR is probably going to be closed or formula deleted label Feb 20, 2024
@chenrui333 chenrui333 added this pull request to the merge queue Feb 20, 2024
@chenrui333 chenrui333 added the python-vendoring Part of the Python resource vendoring project label Feb 20, 2024
@chenrui333 chenrui333 removed this pull request from the merge queue due to a manual request Feb 20, 2024
@chenrui333 chenrui333 added the automerge-skip `brew pr-automerge` will skip this pull request label Feb 20, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 20, 2024
Merged via the queue into Homebrew:master with commit 2f50b60 Feb 20, 2024
@clason
Copy link
Copy Markdown
Contributor

clason commented Feb 20, 2024

Note that arxiv_latex_cleaner depends on this. (Nvm, I see that the dependency resolution isn't updated unless you reinstall the formula after the change.)

@cho-m
Copy link
Copy Markdown
Member Author

cho-m commented Feb 20, 2024

Note that arxiv_latex_cleaner depends on this. (Nvm, I see that the dependency resolution isn't updated unless you reinstall the formula after the change.)

We could revision bump to force #163115. I am not sure how well brew handles this situation.

@cho-m cho-m deleted the python-abseil-remove branch February 20, 2024 15:54
@clason
Copy link
Copy Markdown
Contributor

clason commented Feb 20, 2024

It doesn't, is how ;) Hence my comment.

(Something to keep in mind during the Great Python Yeeting.)

@timsutton
Copy link
Copy Markdown
Contributor

My interpretation of this then, is if we:

  • have a python-* formula which was depended on by a relatively small number of formulas (say, 1-4), and
  • those formulas are unlikely to be updated in the time between vendoring and removal of said python-* formulae

then, we should proactively revision-bump the formulas that depended on them, or at least those which aren't updated very frequently. It may make sense to just to just do a revision bump at the same time as vendoring if we'd expect to need to circle back to them anyway later just to revision-bump.

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. maintainer feedback Additional maintainers' opinions may be needed marked for removal/rejection PR is probably going to be closed or formula deleted outdated PR was locked due to age python-vendoring Part of the Python resource vendoring project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants