Skip to content

fix(gram): use-env-variables-in-ci-to-target-host#7243

Merged
Zaimwa9 merged 2 commits intomainfrom
fix/generate-open-api-scheme-for-gram-with-variable-host
Apr 15, 2026
Merged

fix(gram): use-env-variables-in-ci-to-target-host#7243
Zaimwa9 merged 2 commits intomainfrom
fix/generate-open-api-scheme-for-gram-with-variable-host

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented Apr 15, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Fix MCP OpenAPI spec generation in CI using localhost URLs instead of production URLs for Gram. Bug introduced as the mcp openAPI spec dynamically sets the the securityScheme and server.urls

  • Use github variables to set the target hosts

How did you test this code?

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner April 15, 2026 13:44
@Zaimwa9 Zaimwa9 requested review from gagantrivedi and removed request for a team April 15, 2026 13:44
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Apr 15, 2026 2:47pm
flagsmith-frontend-preview Ignored Ignored Preview Apr 15, 2026 2:47pm
flagsmith-frontend-staging Ignored Ignored Preview Apr 15, 2026 2:47pm

Request Review

@github-actions github-actions bot added the fix label Apr 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7243 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7243 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7243 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-7243 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7243 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7243 Finished ✅ Results

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.29%. Comparing base (1cd16ea) to head (3dcd6da).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7243   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files        1351     1351           
  Lines       50747    50759   +12     
=======================================
+ Hits        49880    49892   +12     
  Misses        867      867           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  44 seconds
commit  e1d7dc2
info  🔄 Run: #16065 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  56.6 seconds
commit  e1d7dc2
info  🔄 Run: #16065 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  57.8 seconds
commit  e1d7dc2
info  🔄 Run: #16065 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 8 seconds
commit  e1d7dc2
info  🔄 Run: #16065 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  43.8 seconds
commit  3dcd6da
info  🔄 Run: #16067 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  28.9 seconds
commit  3dcd6da
info  🔄 Run: #16067 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  56.7 seconds
commit  3dcd6da
info  🔄 Run: #16067 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute, 1 second
commit  3dcd6da
info  🔄 Run: #16067 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

Visual Regression

16 screenshots compared. See report for details.
View full report

Co-authored-by: Evandro Myller <22429+emyller@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added fix and removed fix labels Apr 15, 2026
@Zaimwa9 Zaimwa9 merged commit f35369b into main Apr 15, 2026
34 checks passed
@Zaimwa9 Zaimwa9 deleted the fix/generate-open-api-scheme-for-gram-with-variable-host branch April 15, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants