fix: Detection of HW caps and Num Cpus for FreeBSD(R) and OpenBSD(R)#1269
fix: Detection of HW caps and Num Cpus for FreeBSD(R) and OpenBSD(R)#1269Martinfx wants to merge 1 commit intoARM-software:mainfrom
Conversation
|
Hi @Martinfx , Can you sign-off your commit please. We forgot it in the last PR unfortunately. |
|
@Martinfx I also suggest the following commit and pull request title: fix: Detection of HW caps and Num Cpus for FreeBSD(R) and OpenBSD(R) |
Martinfx
force-pushed
the
max-freeebsd-fix-ncpu
branch
from
d90184d to
97df729
Compare
Martinfx
changed the title
ok. no problem. |
|
@Martinfx |
Martinfx
force-pushed
the
max-freeebsd-fix-ncpu
branch
from
5e831a8 to
fad3d65
Compare
Martinfx
force-pushed
the
max-freeebsd-fix-ncpu
branch
2 times, most recently
from
7dca859 to
2d8057c
Compare
Signed-off-by: Martin Filla <freebsd@sysctl.cz>
Martinfx
force-pushed
the
max-freeebsd-fix-ncpu
branch
from
2d8057c to
bdadbf6
Compare
|
@gunes-arm |
|
Hi, @gunes-arm , it is ok ? |
| #include <asm/hwcap.h> /* Get HWCAP bits from asm/hwcap.h */ | ||
| #include <sys/auxv.h> | ||
| #elif (defined(__OpenBSD__) || defined(__FreeBSD__) || defined(__APPLE__)) && defined(__aarch64__) | ||
| #include <sys/auxv.h> |
There was a problem hiding this comment.
src/common/cpuinfo/CpuInfo.cpp:61:10: fatal error: 'sys/auxv.h' file not found
[2026-03-30T10:27:39.458Z] 61 | #include <sys/auxv.h>
We had this error in the CI for macOS build. It'd be better if you confine these inclusions to OpenBSD and FreeBSD as you don't change anything for macOS HW capability detection.
| defined(__APPLE__)) /* #elif(BARE_METAL) && defined(__aarch64__) */ | ||
|
|
||
| #elif defined(__aarch64__) && (defined(__OpenBSD__) || defined(__FreeBSD__)) | ||
| /* #elif(BARE_METAL) && defined(__aarch64__) */ |
There was a problem hiding this comment.
This doesn't seem to be in the right place. And, is this accurate?
2 participants
No description provided.