fix(twenty-server): preserve input order in bulk API responses

Bulk APIs (createMany, mergeMany, findDuplicates) were returning records
in arbitrary order because they use WHERE id IN (...) without ORDER BY.

Fixed by reordering fetched records to match the original input order.

Affected endpoints:
- createMany: fetchUpsertedRecords
- mergeMany: getRecordsToMerge (for dry-run and actual merge)
- findDuplicates: when fetching by IDs

Author: FelixMalfait

packages/twenty-server/src/engine/api/common/common-query-runners/common-create-many-query-runner/common-create-many-query-runner.service.ts

@@ -419,18 +419,25 @@ export class CommonCreateManyQueryRunnerService extends CommonBaseQueryRunnerSer
       flatFieldMetadataMaps,
     });
 
+    const orderedIds = objectRecords.generatedMaps.map((record) => record.id);
+
     const upsertedRecords = await queryBuilder
       .setFindOptions({
         select: columnsToSelect,
       })
       .where({
-        id: In(objectRecords.generatedMaps.map((record) => record.id)),
+        id: In(orderedIds),
       })
       .withDeleted()
       .take(QUERY_MAX_RECORDS)
       .getMany();
 
-    return upsertedRecords as ObjectRecord[];
+    // Preserve original input order by sorting results to match orderedIds
+    const recordsById = new Map(
+      upsertedRecords.map((record) => [record.id, record]),
+    );
+
+    return orderedIds.map((id) => recordsById.get(id) as ObjectRecord);
   }
 
   async processQueryResult(

packages/twenty-server/src/engine/api/common/common-query-runners/common-find-duplicates-query-runner.service.ts

@@ -71,12 +71,21 @@ export class CommonFindDuplicatesQueryRunnerService extends CommonBaseQueryRunne
     });
 
     if (isDefined(args.ids) && args.ids.length > 0) {
-      objectRecords = (await existingRecordsQueryBuilder
+      const fetchedRecords = (await existingRecordsQueryBuilder
         .where({ id: In(args.ids) })
         .setFindOptions({
           select: columnsToSelect,
         })
         .getMany()) as ObjectRecord[];
+
+      // Preserve original input order
+      const recordsById = new Map(
+        fetchedRecords.map((record) => [record.id, record]),
+      );
+
+      objectRecords = args.ids
+        .map((id) => recordsById.get(id))
+        .filter(isDefined);
     } else if (args.data && !isEmpty(args.data)) {
       objectRecords = args.data;
     }

packages/twenty-server/src/engine/api/common/common-query-runners/common-merge-many-query-runner.service.ts

@@ -137,25 +137,33 @@ export class CommonMergeManyQueryRunnerService extends CommonBaseQueryRunnerServ
       flatFieldMetadataMaps: context.flatFieldMetadataMaps,
     });
 
-    const recordsToMerge = await context.repository.find({
+    const fetchedRecords = await context.repository.find({
       where: { id: In(args.ids) },
       select: columnsToSelect,
     });
 
-    if (recordsToMerge.length !== args.ids.length) {
+    if (fetchedRecords.length !== args.ids.length) {
       throw new CommonQueryRunnerException(
         'One or more records not found',
         CommonQueryRunnerExceptionCode.RECORD_NOT_FOUND,
         { userFriendlyMessage: msg`One or more records were not found.` },
       );
     }
 
+    // Preserve original input order
+    const recordsById = new Map(
+      fetchedRecords.map((record) => [record.id, record]),
+    );
+    const recordsToMerge = args.ids.map(
+      (id) => recordsById.get(id) as ObjectRecord,
+    );
+
     if (args.dryRun && args.selectedFieldsResult.relations) {
       await this.processNestedRelationsHelper.processNestedRelations({
         flatObjectMetadataMaps: context.flatObjectMetadataMaps,
         flatFieldMetadataMaps: context.flatFieldMetadataMaps,
         parentObjectMetadataItem: context.flatObjectMetadata,
-        parentObjectRecords: recordsToMerge as ObjectRecord[],
+        parentObjectRecords: recordsToMerge,
         relations: args.selectedFieldsResult.relations as Record<
           string,
           FindOptionsRelations<ObjectLiteral>
@@ -168,7 +176,7 @@ export class CommonMergeManyQueryRunnerService extends CommonBaseQueryRunnerServ
       });
     }
 
-    return recordsToMerge as ObjectRecord[];
+    return recordsToMerge;
   }
 
   private validateAndGetPriorityRecord(