Code review returns: Charles

Author: martmull

packages/create-twenty-app/tsconfig.json

@@ -3,8 +3,8 @@
   "compilerOptions": {
     "outDir": "./dist",
     "rootDir": "./src",
-    "module": "commonjs",
-    "target": "ES2022",
+    "module": "esnext",
+    "target": "es2022",
     "moduleResolution": "node",
     "esModuleInterop": true,
     "allowSyntheticDefaultImports": true,

packages/twenty-sdk/eslint.config.mjs

@@ -2,10 +2,13 @@ import baseConfig from '../../eslint.config.mjs';
 
 export default [
   ...baseConfig,
+  {
+    ignores: ['**/dist/**'],
+  },
   {
     rules: {
       'no-console': 'off',
     },
-    ignores: ['**/dist/**', 'vite.config.ts'],
+    ignores: ['src/**/*.ts', '!src/cli/**/*.ts'],
   },
 ];

packages/twenty-sdk/tsconfig.cli.json

@@ -3,14 +3,15 @@
   "compilerOptions": {
     "outDir": "./dist/cli",
     "rootDir": "./src/cli",
-    "module": "commonjs",
-    "target": "ES2022",
+    "module": "esnext",
+    "target": "es2022",
     "esModuleInterop": true,
+    "allowUnreachableCode": false,
+    "declaration": true,
+    "declarationMap": true,
     "allowSyntheticDefaultImports": true,
     "strict": true,
     "forceConsistentCasingInFileNames": true,
-    "declaration": true,
-    "declarationMap": true,
   },
   "include": ["src/cli/**/*.ts"],
   "exclude": ["node_modules", "dist", "**/*.test.ts", "**/*.spec.ts", "**/*.e2e-spec.ts", "**/__tests__/**"]

packages/twenty-sdk/tsconfig.json

@@ -1,10 +1,13 @@
 {
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "declaration": true,
     "outDir": "./dist",
     "rootDir": "src",
+    "module": "esnext",
+    "target": "es2022",
+    "esModuleInterop": true,
     "allowUnreachableCode": false,
+    "declaration": true,
     "strictNullChecks": true,
     "alwaysStrict": true,
     "noImplicitAny": true,
@@ -13,6 +16,15 @@
       "@/*": ["./src/*"]
     }
   },
-  "include": ["src/**/*.ts"],
+  "files": [],
+  "references": [
+    {
+      "path": "./tsconfig.cli.json"
+    },
+    {
+      "path": "./tsconfig.e2e.json"
+    },
+  ],
+  "include": ["src/**/*.ts", "vite.config.ts"],
   "exclude": ["src/cli/**"]
 }

packages/twenty-sdk/vite.config.ts

@@ -1,9 +1,7 @@
-// @ts-ignore
 import path from 'path';
 import { defineConfig } from 'vite';
 import dts from 'vite-plugin-dts';
 import tsconfigPaths from 'vite-tsconfig-paths';
-// @ts-ignore
 import packageJson from './package.json';
 
 const moduleEntries = Object.keys((packageJson as any).exports || {})