Skip to content

Commit 2c5a757

Browse files
authored
Clean workflow run stoppage flag (#16950)
Flag has never been removed. Feature allows to stop a running workflow run.
1 parent 1113c20 commit 2c5a757

File tree

7 files changed

+2
-19
lines changed

7 files changed

+2
-19
lines changed

packages/twenty-front/src/generated-metadata/graphql.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1365,7 +1365,6 @@ export enum FeatureFlagKey {
13651365
IS_STRIPE_INTEGRATION_ENABLED = 'IS_STRIPE_INTEGRATION_ENABLED',
13661366
IS_TIMELINE_ACTIVITY_MIGRATED = 'IS_TIMELINE_ACTIVITY_MIGRATED',
13671367
IS_UNIQUE_INDEXES_ENABLED = 'IS_UNIQUE_INDEXES_ENABLED',
1368-
IS_WORKFLOW_RUN_STOPPAGE_ENABLED = 'IS_WORKFLOW_RUN_STOPPAGE_ENABLED',
13691368
IS_WORKSPACE_CREATION_V2_ENABLED = 'IS_WORKSPACE_CREATION_V2_ENABLED'
13701369
}
13711370

packages/twenty-front/src/generated/graphql.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1340,7 +1340,6 @@ export enum FeatureFlagKey {
13401340
IS_STRIPE_INTEGRATION_ENABLED = 'IS_STRIPE_INTEGRATION_ENABLED',
13411341
IS_TIMELINE_ACTIVITY_MIGRATED = 'IS_TIMELINE_ACTIVITY_MIGRATED',
13421342
IS_UNIQUE_INDEXES_ENABLED = 'IS_UNIQUE_INDEXES_ENABLED',
1343-
IS_WORKFLOW_RUN_STOPPAGE_ENABLED = 'IS_WORKFLOW_RUN_STOPPAGE_ENABLED',
13441343
IS_WORKSPACE_CREATION_V2_ENABLED = 'IS_WORKSPACE_CREATION_V2_ENABLED'
13451344
}
13461345

packages/twenty-front/src/modules/action-menu/actions/record-actions/constants/WorkflowRunsActionsConfig.tsx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,8 @@ export const WORKFLOW_RUNS_ACTIONS_CONFIG = inheritActionsFromDefaultConfig({
6060
type: ActionType.Standard,
6161
scope: ActionScope.RecordSelection,
6262
Icon: IconPlayerStop,
63-
shouldBeRegistered: ({
64-
selectedRecord,
65-
isWorkflowRunStoppageEnabled,
66-
}) => {
67-
return (
68-
selectedRecord?.status === 'RUNNING' && isWorkflowRunStoppageEnabled
69-
);
63+
shouldBeRegistered: ({ selectedRecord }) => {
64+
return selectedRecord?.status === 'RUNNING';
7065
},
7166
availableOn: [
7267
ActionViewType.SHOW_PAGE,

packages/twenty-front/src/modules/action-menu/actions/types/ShouldBeRegisteredFunctionParams.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,4 @@ export type ShouldBeRegisteredFunctionParams = {
2626
objectMetadataItemNameSingular: string,
2727
) => boolean;
2828
forceRegisteredActionsByKey: Record<string, boolean | undefined>;
29-
isWorkflowRunStoppageEnabled: boolean;
3029
};

packages/twenty-front/src/modules/action-menu/hooks/useShouldActionBeRegisteredParams.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,20 +14,15 @@ import { useObjectPermissionsForObject } from '@/object-record/hooks/useObjectPe
1414
import { hasAnySoftDeleteFilterOnViewComponentSelector } from '@/object-record/record-filter/states/hasAnySoftDeleteFilterOnView';
1515
import { recordStoreFamilyState } from '@/object-record/record-store/states/recordStoreFamilyState';
1616
import { useRecoilComponentValue } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValue';
17-
import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';
1817
import { useContext } from 'react';
1918
import { useRecoilCallback, useRecoilValue } from 'recoil';
20-
import { FeatureFlagKey } from '~/generated/graphql';
2119

2220
export const useShouldActionBeRegisteredParams = ({
2321
objectMetadataItem,
2422
}: {
2523
objectMetadataItem?: ObjectMetadataItem;
2624
}): ShouldBeRegisteredFunctionParams => {
2725
const { sortedFavorites: favorites } = useFavorites();
28-
const isWorkflowRunStoppageEnabled =
29-
useIsFeatureEnabled(FeatureFlagKey.IS_WORKFLOW_RUN_STOPPAGE_ENABLED) ??
30-
false;
3126

3227
const contextStoreTargetedRecordsRule = useRecoilComponentValue(
3328
contextStoreTargetedRecordsRuleComponentState,
@@ -124,6 +119,5 @@ export const useShouldActionBeRegisteredParams = ({
124119
getTargetObjectReadPermission: getObjectReadPermission,
125120
getTargetObjectWritePermission: getObjectWritePermission,
126121
forceRegisteredActionsByKey,
127-
isWorkflowRunStoppageEnabled,
128122
};
129123
};

packages/twenty-server/src/engine/core-modules/feature-flag/enums/feature-flag-key.enum.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ export enum FeatureFlagKey {
1010
IS_RECORD_PAGE_LAYOUT_ENABLED = 'IS_RECORD_PAGE_LAYOUT_ENABLED',
1111
IS_PUBLIC_DOMAIN_ENABLED = 'IS_PUBLIC_DOMAIN_ENABLED',
1212
IS_EMAILING_DOMAIN_ENABLED = 'IS_EMAILING_DOMAIN_ENABLED',
13-
IS_WORKFLOW_RUN_STOPPAGE_ENABLED = 'IS_WORKFLOW_RUN_STOPPAGE_ENABLED',
1413
IS_DASHBOARD_V2_ENABLED = 'IS_DASHBOARD_V2_ENABLED',
1514
IS_TIMELINE_ACTIVITY_MIGRATED = 'IS_TIMELINE_ACTIVITY_MIGRATED',
1615
IS_ROW_LEVEL_PERMISSION_PREDICATES_ENABLED = 'IS_ROW_LEVEL_PERMISSION_PREDICATES_ENABLED',

packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.spec.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,6 @@ describe('WorkspaceEntityManager', () => {
219219
IS_RECORD_PAGE_LAYOUT_ENABLED: false,
220220
IS_PUBLIC_DOMAIN_ENABLED: false,
221221
IS_EMAILING_DOMAIN_ENABLED: false,
222-
IS_WORKFLOW_RUN_STOPPAGE_ENABLED: false,
223222
IS_DASHBOARD_V2_ENABLED: false,
224223
IS_TIMELINE_ACTIVITY_MIGRATED: false,
225224
IS_GLOBAL_WORKSPACE_DATASOURCE_ENABLED: false,
@@ -248,7 +247,6 @@ describe('WorkspaceEntityManager', () => {
248247
IS_RECORD_PAGE_LAYOUT_ENABLED: false,
249248
IS_PUBLIC_DOMAIN_ENABLED: false,
250249
IS_EMAILING_DOMAIN_ENABLED: false,
251-
IS_WORKFLOW_RUN_STOPPAGE_ENABLED: false,
252250
IS_DASHBOARD_V2_ENABLED: false,
253251
IS_ROW_LEVEL_PERMISSION_PREDICATES_ENABLED: false,
254252
},

0 commit comments

Comments
 (0)