Refactoring to create absolutePathToUrlRegexp#796
Merged
connor4312 merged 4 commits intomasterfrom Oct 19, 2020
Merged
Conversation
connor4312
reviewed
Oct 13, 2020
connor4312
approved these changes
Oct 13, 2020
Member
connor4312
left a comment
connor4312
left a comment
There was a problem hiding this comment.
Let me know when you're ready for this to be merged
Contributor
Author
|
@connor4312 I just added the unit tests, so it's ready to merge. Thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start using absolutePathToUrlRegexp instead of absolutePathToUrl so we can customize the Regexp we use for Blazor scenarios
@connor4312 If you like this approach, I'll add some unit tests for BrowserSourcePathResolver.absolutePathToUrlRegexp