Closed
Conversation
Member
|
LGTM if CI is happy. |
Member
|
lgtm |
Member
Author
|
RE: CI, there are two runs in progress at the moment. I'm waiting for them to complete before I start testing this one. |
Member
|
@bnoordhuis just queue it up even if there are runs in play, many of the targets have multiple slaves to make it workable and they'll queue in any case but you'll still have the number / url |
Member
Author
|
https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/192/ - I've had concurrent runs interact poorly with each other in the past (e.g. hitting the system-wide file descriptor limit) but let's hope for the best. |
bnoordhuis
added a commit
that referenced
this pull request
Feb 25, 2015
PR-URL: #940 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Member
|
landed @ 739fda1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R=@indutny, /cc @rvagg