Skip to content

Commit 573aeca

Browse files
Josef BacikChris Mason
authored andcommitted
Btrfs: actually limit the size of delalloc range
So forever we have had this thing to limit the amount of delalloc pages we'll setup to be written out to 128mb. This is because we have to lock all the pages in this range, so anything above this gets a bit unweildly, and also without a limit we'll happily allocate gigantic chunks of disk space. Turns out our check for this wasn't quite right, we wouldn't actually limit the chunk we wanted to write out, we'd just stop looking for more space after we went over the limit. So if you do a giant 20gb dd on my box with lots of ram I could get 2gig extents. This is fine normally, except when you go to relocate these extents and we can't find enough space to relocate these moster extents, since we have to be able to allocate exactly the same sized extent to move it around. So fix this by actually enforcing the limit. With this patch I'm no longer seeing giant 1.5gb extents. Thanks, Signed-off-by: Josef Bacik <jbacik@fusionio.com> Signed-off-by: Chris Mason <chris.mason@fusionio.com>
1 parent a482039 commit 573aeca

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

fs/btrfs/extent_io.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1481,10 +1481,12 @@ static noinline u64 find_delalloc_range(struct extent_io_tree *tree,
14811481
*end = state->end;
14821482
cur_start = state->end + 1;
14831483
node = rb_next(node);
1484-
if (!node)
1485-
break;
14861484
total_bytes += state->end - state->start + 1;
1487-
if (total_bytes >= max_bytes)
1485+
if (total_bytes >= max_bytes) {
1486+
*end = *start + max_bytes - 1;
1487+
break;
1488+
}
1489+
if (!node)
14881490
break;
14891491
}
14901492
out:

0 commit comments

Comments
 (0)